fix: Fixed a hidden logging bug in add_tokenize_docs in word_count.py #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riddhimaan-Senapati
changed the title
ginic
approved these changes
Jun 5, 2025
Contributor
ginic
left a comment
ginic
left a comment
There was a problem hiding this comment.
Thank you @Riddhimaan-Senapati! I appreciate the fix and attention to detail and will merge it in.
The screenshots of the code in the description are nice, but GitHub actually does that for you and shows a code diff under the "Files changed" tab in the Pull request, so you don't need to add that in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a hidden logging bug in word_count.py in
add_tokenize_docswhere it was incorrectly logging the case sensitive case as case insensitive.Original
Fix:
